Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE11 specific code from feedback.js #4622

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Remove IE11 specific code from feedback.js #4622

merged 1 commit into from
Feb 7, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 7, 2025

What / Why

Visual Changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4622 February 7, 2025 14:47 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4622 February 7, 2025 16:10 Inactive
@AshGDS AshGDS self-assigned this Feb 7, 2025
@AshGDS AshGDS marked this pull request as ready for review February 7, 2025 16:18
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AshGDS. All looks good to me and thanks for mentioning the "hide whitespace changes" suggestion as well: very handy!

@AshGDS AshGDS merged commit 57ec565 into main Feb 7, 2025
12 checks passed
@AshGDS AshGDS deleted the ie-11-js-removal branch February 7, 2025 16:39
@andysellick andysellick mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 specific code in our Feedback component
3 participants