Remove full stop from default hint text in "Checkboxes" component #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
4589_Checkboxes_Remove-full-stop
branch
from
02a8d40 to
5e52965
Compare
jon-kirwan
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks, @davidtrussler! Looks good to me. By the way, you can link the issue from the development tab on the right side of the PR, and it will automatically close when the PR is merged.
Great, thanks Jon, have linked it to the issue now as well. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes the full stop from the default hint text for the component.
Why
This was raised in this issue and makes this component consistent with the way hint text is presented in the Design System.
Visual Changes