Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govuk-text-break-word style to markdown links #4603

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Feb 3, 2025

What

Add govuk-text-break-word style to markdown links.

https://components-gem-pr-4603.herokuapp.com/component-guide/govspeak#how-it-looks

Why

Enable long words or URLs to break and wrap onto a new line in Govspeak components.

Visual Changes

https://www.gov.uk/guidance/local-authority-collected-waste-definition-of-terms

Before

After

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4603 February 3, 2025 14:16 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4603 February 3, 2025 14:18 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review February 4, 2025 15:07
Enable long words or URLs to break and wrap onto a new line in Govspeak components.
@jon-kirwan jon-kirwan force-pushed the add-govuk-text-break-word-style-to-markdown-links branch from 2d8e1a5 to 11fe3ab Compare February 4, 2025 15:08
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4603 February 4, 2025 15:08 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!, way ahead of me as well in where else we can apply the typography helper to help resolve other issues - #4462

@jon-kirwan
Copy link
Contributor Author

Thanks for the review, @MartinJJones! 👍 It looks like it was added fairly recently: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md?plain=1#L223. I've also opened a separate issue to explore its use with headings #4607

@jon-kirwan jon-kirwan merged commit 3c67955 into main Feb 4, 2025
12 checks passed
@jon-kirwan jon-kirwan deleted the add-govuk-text-break-word-style-to-markdown-links branch February 4, 2025 15:36
@MartinJJones MartinJJones mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible horizontal overflow when long words are used in some components
3 participants