Set aria-label text in govuk_logo.html to "GOV.UK" #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we use the design system as of truth for the GOVUK logo, the value for the aria-label attribute should always be set to "GOV.UK", this means we can remove support for any custom values to be set other than "GOV.UK" and make future updates to the logo a little easier.
hannalaakso
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks Martin, this is a nice tidy up 👍
For reference, the GOV.UK Design System also hardcodes the value of this aria-label so it makes sense for us to do the same.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the govuk_logo.html.erb template to set the arial-label attribute value to "GOV.UK" and remove support for custom values to be passed in.
Why
Help make future updates to the logo a little easier, ideally in the future we would simply be able to copy and past the required SVG code into the
govuk_logo.html.erbtemplate with no further changes required.Trello card