Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation strings for cookie banner confirmation message #3191

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Add translation strings for cookie banner confirmation message #3191

merged 3 commits into from
Jan 18, 2023

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Jan 17, 2023 •
edited
Loading

What

Add translation strings for text toggled from JavaScript for the cookie banner confirmation message.

Why

We should update the strings so that they can be translated.

Anything else

  • Updated missing translations here

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 10:56 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from 4131ddb to abd7db6 Compare January 17, 2023 11:00
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 11:00 Inactive
@jon-kirwan jon-kirwan linked an issue Jan 17, 2023 that may be closed by this pull request
Cookies banner component isn't translatable #1930
Closed
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from abd7db6 to 6f3434f Compare January 17, 2023 12:12
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 12:12 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from 6f3434f to de27e56 Compare January 17, 2023 12:42
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 12:42 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from de27e56 to 495f151 Compare January 17, 2023 14:32
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 14:32 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from 495f151 to 68866cb Compare January 17, 2023 15:24
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 15:24 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from 68866cb to 8e0a822 Compare January 17, 2023 16:41
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 17, 2023 16:41 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from 8e0a822 to de4f9ca Compare January 18, 2023 16:01
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 18, 2023 16:01 Inactive
@jon-kirwan jon-kirwan force-pushed the add-translations-for-cookie-banner branch from de4f9ca to 17f42f1 Compare January 18, 2023 16:02
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3191 January 18, 2023 16:02 Inactive
MartinJJones
MartinJJones approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jon-kirwan jon-kirwan merged commit 160c5b5 into main Jan 18, 2023
@jon-kirwan jon-kirwan deleted the add-translations-for-cookie-banner branch January 18, 2023 16:40
@JamesCGDS JamesCGDS mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinJJones MartinJJones MartinJJones approved these changes

@maxgds maxgds Awaiting requested review from maxgds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookies banner component isn't translatable
3 participants
@jon-kirwan @MartinJJones @govuk-ci