Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crown alignment in the header properly #2206

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

injms
Copy link
Contributor

@injms injms commented Jul 12, 2021

What

Previous fix in #2134 was a hack - this fixes the alignment properly by updating the dimensions of the crown to match the crown dimensions in the Design System's header component.

Many thanks to @kr8n3r for spotting the reason why this misalignment was happening.

Fixes #2187.

Why

The previous fix was a hack that didn't solve the root cause of the problem - this fixes it properly.

Visual Changes

Before After
image image

Previous fix in #2134 was a hack - this fixes the alignment properly by
updating the dimensions of the crown to match the crown dimensions in
the Design System's header component.

Many thanks to @kr8n3r for spotting the reason why this misalignment was
happening.

Fixes #2187.
@bevanloon bevanloon temporarily deployed to govuk-publis-fix-header-hojhe4 July 12, 2021 10:00 Inactive
@injms injms marked this pull request as ready for review July 12, 2021 10:10
@injms injms merged commit 0ff9f48 into master Jul 12, 2021
@injms injms deleted the fix-header-logo-alignment-properly branch July 12, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mysterious crown logo misalignment
3 participants