Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm start #306

Merged
merged 3 commits into from
Sep 12, 2016
Merged

Add npm start #306

merged 3 commits into from
Sep 12, 2016

Conversation

gemmaleigh
Copy link
Contributor

What problem does the pull request solve?

Ensure that 'npm start' can be used to start the govuk_elements application.

If no "start" property is specified on the "scripts" object, it will
run node server.js.

Screenshots (if appropriate):

What type of change is it?

  • New feature (non-breaking change which adds functionality)

@NickColley
Copy link
Contributor

Could we change the scripts in package.json to look like

  "scripts":{
    "test": "standard && grunt test",
    "start": "grunt"
  },

(package.json can get the binary globals from the local node_modules so you don't need to hard code them)

Then remove start.js?

@NickColley
Copy link
Contributor

@robinwhittleton robinwhittleton merged commit 5657a45 into master Sep 12, 2016
@robinwhittleton robinwhittleton deleted the add-npm-start branch September 12, 2016 11:01
This was referenced Sep 12, 2016
gemmaleigh added a commit that referenced this pull request Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants