Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specialist topics #108

Merged
merged 1 commit into from
May 17, 2024
Merged

Remove specialist topics #108

merged 1 commit into from
May 17, 2024

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented May 17, 2024

What

Removing specialist topics from publishing-api, impacted the test in govuk_document_types and it is now failing. Specialist topics have not been removed from this repository. This PR removes them. The impact of this change needs to be carefully considered before this PR is merged and it needs to be approved.

Why

In order to fix the failing test.

@unoduetre unoduetre force-pushed the remove-specialist-topics branch from b642a94 to a293550 Compare May 17, 2024 12:31
@unoduetre unoduetre force-pushed the remove-specialist-topics branch from a293550 to 20b3794 Compare May 17, 2024 12:32
@unoduetre unoduetre marked this pull request as ready for review May 17, 2024 12:50
@unoduetre unoduetre requested a review from hannako May 17, 2024 12:52
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mat

@unoduetre unoduetre merged commit 2db5e21 into main May 17, 2024
17 checks passed
@unoduetre unoduetre deleted the remove-specialist-topics branch May 17, 2024 12:57
unoduetre added a commit that referenced this pull request May 17, 2024
* BREAKING: Remove specialist topics ([PR #108](#108))
* Fix incorrect spec context format
@unoduetre unoduetre mentioned this pull request May 17, 2024
unoduetre added a commit that referenced this pull request May 17, 2024
* BREAKING: Remove specialist topics ([PR #108](#108))
* Fix incorrect spec context format
unoduetre added a commit that referenced this pull request May 17, 2024
* BREAKING: Remove specialist topics ([PR #108](#108))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants