Fix toolkit font stack overrides #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaleigh
added a commit
that referenced
this pull request
Oct 13, 2016
# 2.0.0 - Remove the images path override from the helpers partial ([PR #292](alphagov/govuk_elements#292)). This will break background images that are currently using the `file-url` function from [the url-helpers partial in the frontend toolkit](https://github.com/alphagov/govuk_frontend_toolkit/blob/d54c9b2 6d314a6e6cb50ba90f6e96ca50049498f/stylesheets/_url-helpers.scss). As `$path` will vary from project to project you will need to define this in your main application stylesheet. - Bump govuk frontend toolkit to 4.16.1 ([PR #288](alphagov/govuk_elements#288)). This adds space key activation to links with a role of button. - Form validation patterns for conditionally revealing content ([PR #286](alphagov/govuk_elements#286)) - Centre text on full-width buttons ([PR #289](alphagov/govuk_elements#289)) - Lint JS code using [StandardJS](http://standardjs.com/) ([PR #290](alphagov/govuk_elements#290)) *This version deprecates external link styles. If your service has user research that indicates that external links are useful (or not) then we’d like to hear from you either on Slack, [digital-service-designers](https://groups.google.com/a/digital.cabinet- office.gov.uk/forum/#!forum/digital-service-designers) or [opening an issue](https://github.com/alphagov/govuk_elements/issues/new).* # 1.2.2 - Bump govuk frontend toolkit to 4.14.4 (PR #278) - Add a .column-full class (PR #270) - Add a file upload example (PR #268) - Remove the blue outline from the main content area (PR #265) - Fix legend text wrapping in IE (PR #248) # 1.2.1 - Consistent spacing underneath block labels and toggled content (PR #229) - Remove underlines from abbreviations in Firefox (PR #241)
Rename to not use an underscore, so a new stylesheet is created.
gemmaleigh
force-pushed
the
fix-toolkit-font-stack
branch
from
64cbac5 to
9cadd5f
Compare
|
Looks good. |
robinwhittleton
pushed a commit
that referenced
this pull request
Oct 13, 2016
Breaking changes: - #244 Migrate documentation into a seperate application All changes: - Bump all GOV.UK assets to their latest versions - Remove duplicate GOV.UK assets copied to the app - #241 Warn against using the prototype kit to build production services - #268 Automatically keep the latest release branch up to date. This can be used to update the kit - #270 Add a new stylesheet for the unbranded layout to fix font issues - #257 Make CSS output easier to debug (with sourcemaps) - #237 Make links with role="button" behave like buttons - #224 Lint the prototype kit’s codebase using Standard. This only applies to the kit’s codebase - there’s no requirement for your app to meet this
robinwhittleton
pushed a commit
that referenced
this pull request
Oct 13, 2016
Breaking changes: - #244 Migrate documentation into a separate application All changes: - Bump all GOV.UK assets to their latest versions - Remove duplicate GOV.UK assets copied to the app - #241 Warn against using the prototype kit to build production services - #268 Automatically keep the latest release branch up to date. This can be used to update the kit - #270 Add a new stylesheet for the unbranded layout to fix font issues - #257 Make CSS output easier to debug (with sourcemaps) - #237 Make links with role="button" behave like buttons - #224 Lint the prototype kit’s codebase using Standard. This only applies to the kit’s codebase - there’s no requirement for your app to meet this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new stylesheet for the unbranded page and include this in the unbranded layout.
This way the $toolkit-font-stack variable can't affect any other files.
This fixes #256.