Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin validator should support nunjucks functions #2375

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Plugin validator should support nunjucks functions #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- [#2375: Plugin validator should support nunjucks functions](https://github.com/alphagov/govuk-prototype-kit/pull/2375)

## 13.15.0

### New features
Expand Down
1 change: 1 addition & 0 deletions __tests__/fixtures/mockPlugins/valid-plugin/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// intentionally empty, file must just exist for testing purposes.
3 changes: 2 additions & 1 deletion __tests__/fixtures/mockPlugins/valid-plugin/govuk-prototype-kit.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
}
],
"nunjucksFilters": "/filters.js",
"nunjucksFunctions": "/functions.js",
"templates": [
{
"name": "Step by step navigation page",
Expand All @@ -42,4 +43,4 @@
"maxVersion": "5.5.0"
}
]
}
}
1 change: 1 addition & 0 deletions lib/plugins/plugin-validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const knownKeys = [
'nunjucksPaths',
'nunjucksMacros',
'nunjucksFilters',
'nunjucksFunctions',
'sass',
'scripts',
'stylesheets',
Expand Down