Remove selection-buttons.js #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A copy of this file already gets imported and served through https://github.com/alphagov/govuk_prototype_kit/blob/master/server.js#L58. As such, we don't need this file. Relevant discusson: #223 (comment)
This was referenced Aug 9, 2016
|
Thanks @tvararu 👍 |
gemmaleigh
added a commit
to alphagov/govuk_accessibility_sandbox
that referenced
this pull request
Aug 18, 2016
This is already copied from the node_modules/govuk_frontend_toolkit, so there is no need to duplicate it here. A copy of this file already gets imported and served through https://github.com/alphagov/govuk_prototype_kit/blob/master/server.js#L3 8. Related PR for the govuk_prototype kit: alphagov/govuk-prototype-kit#233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of this file already gets imported and served through https://github.com/alphagov/govuk_prototype_kit/blob/master/server.js#L58. As such, we don't need this file.
Relevant discusson: #223 (comment)
How to test
Run the prototype kit locally, and navigate to http://localhost:3000/examples/elements/radio-buttons-checkboxes.
Everything will still work, because
<script src="/public/javascripts/govuk/selection-buttons.js"></script>will map to the file at./govuk_modules/govuk_frontend_toolkit/javascripts/govuk/selection-buttons.js. This can be verified by changing something in the file.