Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using internal Govuk Frontend more widely #2317

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

nataliecarey
Copy link
Contributor

@nataliecarey nataliecarey commented Aug 29, 2023

This should help with the preparation for Frontend v5.

Management and internal pages are now properly isolated:

  • Password page
  • Manage Prototype section
  • 404 page
  • Error pages

These pages now fully use the version of Govuk Frontend specified in our package.json regardless of which version the user has installed.

I've also removed the plugin sanity checks - they predated our cypress tests, are hard-coded with details from govuk-frontend and aren't particularly useful anymore.

Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved the PR so it can be merged while I'm away, but I have a PR Get scripts and assets from config branched from yours that removes the hard coded locations for the assets and scripts.

@nataliecarey nataliecarey merged commit 0ed88cd into main Aug 31, 2023
27 checks passed
@nataliecarey nataliecarey deleted the using-internal-govuk-frontend-more-widely branch August 31, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants