Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin authors can now use scripts with type module #2088

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Plugin authors can now use scripts with type module #2088

merged 1 commit into from
Apr 6, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Apr 5, 2023 •
edited
Loading

See: Allow type="module" on Plug-In scripts

  • Implemented functionality to add type="module"
  • Added/amended unit tests as required
  • Added a cypress test to prove a script of type module can import another script successfully

@BenSurgisonGDS BenSurgisonGDS self-assigned this Apr 5, 2023
@BenSurgisonGDS BenSurgisonGDS force-pushed the implement-script-type-equals-module branch 2 times, most recently from 88d0fd6 to f66491f Compare April 6, 2023 07:01
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review April 6, 2023 07:05
@BenSurgisonGDS BenSurgisonGDS linked an issue Apr 6, 2023 that may be closed by this pull request
Allow type="module" on Plug-In scripts #2078
Closed
2 tasks
nataliecarey
nataliecarey reviewed Apr 6, 2023
View reviewed changes
lib/plugins/plugins.js Outdated
throwIfBadFilepath(config)
function getFileSystemPath ({ packageName, item }) {
// item will either be the plugin path or will be an object containing the plugin path within the src property
item = item.src || item
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially suggested src but I'm having second thoughts.

I think this should be path so it's not too js specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@BenSurgisonGDS BenSurgisonGDS force-pushed the implement-script-type-equals-module branch from f66491f to cc4aaca Compare April 6, 2023 09:19
@BenSurgisonGDS BenSurgisonGDS force-pushed the implement-script-type-equals-module branch from cc4aaca to d2f8fda Compare April 6, 2023 09:30
@ollie-b-gds ollie-b-gds changed the title Implement type equals module Plugin authors can now use scripts with type module Apr 6, 2023
@BenSurgisonGDS BenSurgisonGDS merged commit e8dfa4e into main Apr 6, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the implement-script-type-equals-module branch April 6, 2023 09:46
This was referenced Oct 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

@HannahJMWood HannahJMWood Awaiting requested review from HannahJMWood

@ollie-b-gds ollie-b-gds Awaiting requested review from ollie-b-gds

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow type="module" on Plug-In scripts
2 participants
@BenSurgisonGDS @nataliecarey