Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Task list template to Task list plugin #1915

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Move Task list template to Task list plugin #1915

merged 2 commits into from
Jan 20, 2023

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Jan 18, 2023 •
edited
Loading

See Move templates to plugins

  • Removes task list template from kit
  • Retains task list sass pattern to support task list pages already created from the kit
  • The task list plugin should not be available prior to it being published

@BenSurgisonGDS BenSurgisonGDS self-assigned this Jan 18, 2023
@BenSurgisonGDS BenSurgisonGDS force-pushed the remove-task-list-pattern branch 5 times, most recently from 4356e83 to 4b58863 Compare January 19, 2023 11:07
joelanman
joelanman previously requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@joelanman joelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a blocker as we can't merge this until we figure out how to release it

@BenSurgisonGDS BenSurgisonGDS changed the title Remove Task list pattern Move Task list template to Task list plugin Jan 20, 2023
@BenSurgisonGDS
Copy link
Contributor Author

Just a blocker as we can't merge this until we figure out how to release it

The sass pattern for the task list will stay within the kit to provide support for users who have created a task list based on that sass.

The template for the task list has been removed from the kit and moved to the task list plugin where the sass for the plugin is name spaced with the plugin name as the prefix. See https://github.com/alphagov/govuk-prototype-kit-task-list/tree/namespace-task-list-correctly

@BenSurgisonGDS BenSurgisonGDS dismissed joelanman’s stale review January 20, 2023 11:47

The path to releasing it has been discussed and agreed.

@BenSurgisonGDS BenSurgisonGDS merged commit d2cc61c into main Jan 20, 2023
@BenSurgisonGDS BenSurgisonGDS deleted the remove-task-list-pattern branch January 20, 2023 11:47
@BenSurgisonGDS BenSurgisonGDS mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliecarey nataliecarey nataliecarey approved these changes

@joelanman joelanman joelanman left review comments

Assignees

@BenSurgisonGDS BenSurgisonGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenSurgisonGDS @joelanman @nataliecarey