Add serve and dev scripts #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-add-serve-script
branch
from
2df4f80
to
51ffb28
Compare
lfdebrux
force-pushed
the
ldeb-add-serve-script
branch
2 times, most recently
from
1ddcdae
to
0957992
Compare
We want to make sure users have NODE_ENV=production set when their prototypes are hosted online, because that controls a lot of important behaviour including the password control and HTTPS redirects. To make this easier, this commit adds a command to the cli tool that sets NODE_ENV and then does the build and run. We also add these commands to the starter files package scripts.
lfdebrux
force-pushed
the
ldeb-add-serve-script
branch
from
0957992
to
0bd0d79
Compare
nataliecarey
approved these changes
Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure users have NODE_ENV=production set when their prototypes are hosted online, because that controls a lot of important behaviour including the password control and HTTPS redirects. To make this easier, this commit adds a command to the cli tool that sets NODE_ENV and then does the build and run. We also add these commands to the starter files package scripts.
This is part of resolving #1202, although it keeps the behaviour of
npm startthe same for now.