fix port restart issue #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanman
force-pushed
the
fix-port-bug
branch
from
b391c63 to
cfe571e
Compare
|
it should check and delete in start.js |
| @@ -1,6 +1,7 @@ | |||
| var basicAuth = require('basic-auth'), | |||
| prompt = require('prompt'), | |||
| portScanner = require('portscanner'); | |||
| portScanner = require('portscanner'), | |||
| fs = require('fs'); | |||
There was a problem hiding this comment.
This could be alphabetical.
There was a problem hiding this comment.
mm, it wasn't before either, so lets just focus on the bug fix
|
Nice fix! I added some comments. In particular, port is configured using |
| try { | ||
| port = Number(fs.readFileSync(__dirname+'/../.port.tmp')); | ||
| } catch (e){ | ||
| port = (process.env.PORT || config.port.tmp); |
There was a problem hiding this comment.
I think this should be config.port, not config.port.tmp.
|
LGTM 👍 we can merge as soon as CI passes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix port restart issue #148
when a new port is automatically chosen, it's stored in a file:
/port.tmpwhen the kit restarts on a file change, it looks for the port here first
when the kit is closed (
ctrl+c) theport.tmpfile is deleted.