Update link styles #1014
Merged
Update link styles #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
update-link-styles
branch
from
b25decf
to
c96e5d4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
vanitabarrett
force-pushed
the
update-link-styles
branch
from
c96e5d4
to
844f572
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
lfdebrux
reviewed
May 6, 2021
lfdebrux
reviewed
May 6, 2021
vanitabarrett
force-pushed
the
update-link-styles
branch
from
844f572
to
8b1aaad
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
lfdebrux
approved these changes
May 6, 2021
hannalaakso
reviewed
May 6, 2021
vanitabarrett
force-pushed
the
update-link-styles
branch
from
8b1aaad
to
9856a99
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
hannalaakso
approved these changes
May 10, 2021
There was a problem hiding this comment.
@vanitabarrett Thanks for addressing my comments. This looks good to me 👍
|
Note: need to delete the pre-release before merging |
vanitabarrett
force-pushed
the
update-link-styles
branch
from
9856a99
to
0c60c21
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
|
Build will be failing now as the pre-release has been removed. Needs to be rebased once the new version of GOV.UK Frontend has been added |
added 2 commits
May 13, 2021 16:10
vanitabarrett
force-pushed
the
update-link-styles
branch
from
0c60c21
to
b87d2fe
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-1014
36degrees
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1012
NOTE: This PR currently points at a pre-release of GOV.UK Frontend. This commit should be removed and replaced by a separate PR to bump GOV.UK Frontend to v3.12.0 before this PR is merged.
What
Update the prototype kit to opt into the new link styles.
Update the step-by-step navigation template to make use of the new link styles.
Why
The new link and hover styles will be opt-in until the next major release of GOV.UK Frontend. However, we'd like the prototype kit to take advantage of the new styles when 3.12.0 is released in order to present the most up-to-date version of GOV.UK Frontend.