Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service name in the browser without a refresh #203

Closed
joelanman opened this issue May 27, 2016 · 3 comments
Closed

Update service name in the browser without a refresh #203

joelanman opened this issue May 27, 2016 · 3 comments
Labels
Feature Request User requests a new feature

Comments

@joelanman
Copy link
Contributor

Most other changes get updated in the browser without a refresh, thanks to BrowserSync. However the service name doesn't because it comes from config.js, not an html file.
@joelanman joelanman added the Feature Request User requests a new feature label May 27, 2016
@edwardhorsford
Copy link
Contributor

More generally, should changes to config.js cause a refresh / restart?

@joelanman
Copy link
Contributor Author

They do cause restart, currently not refresh. Tricky because eg port requires restart

tsmorgan pushed a commit to tsmorgan/govuk_prototype_kit that referenced this issue May 27, 2016
@gemmaleigh
Add and remove the .js-hidden class to hide and show content
9f516b6 
Use this rather than hide() and show(), otherwise the changes to the
govuk template in 0.17.0 will ensure that any content with a .js-hidden
class is always hidden (as it should be) when js is enabled.

This is the fix applied to govuk elements in alphagov#203.
@joelanman
Copy link
Contributor Author

closing this - doesnt seem worth the hassle

quis pushed a commit to quis/govuk_prototype_kit that referenced this issue Oct 25, 2017
@gemmaleigh
Update govuk frontend toolkit to 4.2.1
1c0a068 
# 4.2.1

- Track download links using events not pageviews

# 4.2.0

- Add two analytics plugins for download and external link tracking
- Update typography mixins to be mobile first (PR alphagov#157)

# 4.1.1

- Update Accessible Media Player to remove dependency on $.browser (PR
alphagov#206)

# 4.1.0

- Add support for sending the `page` option to
`GOVUK.analytics.trackEvent` (PR alphagov#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request User requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanman @edwardhorsford