Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task list page template #26

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

frankieroberto
Copy link
Contributor

@frankieroberto frankieroberto commented Sep 25, 2023

This adds a Task list page to the common templates plugin, to make it easier for people to prototype task lists using the GOV.UK Prototype Kit.

See Decide what to do with the Prototype Kit Task List plugin.

@frankieroberto
Copy link
Contributor Author

@colinrotherham @stevenjmesser this can be merged and released now.

It bumps the major version of the plugin, as it now depends on v5 of govuk-frontend.

colinrotherham
colinrotherham previously approved these changes Dec 15, 2023
romaricpascal
romaricpascal previously approved these changes Dec 15, 2023
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Wondering if we can mention that this template 'requires GOV.UK Frontend >v5.0.0' (in the template's name maybe?) to reduce risk of confusions for users trying to use it with 4.x., but not really a blocker.

Worth knowing that people will be able to downgrade using the following link as well (to anticipate support answers): http://localhost:3000/manage-prototype/plugins/install?package=%40govuk-prototype-kit%2Fcommon-templates&version=1.2.2 (or npm install @govuk-prototype-kit/common-templates@1.2.2 if they don't mind the command line).

@romaricpascal
Copy link
Member

@frankieroberto Not sure if your thumbs up is for the way to install the previous version or adding extra info to the name, please let me know which. I've quickly mocked up some extra info next to the name, if that's helpful:

  • "for GOV.UK Frontend >=5.0.0"
Screenshot 2023-12-18 at 10 50 05
  • or, slightly more compact, "for GOV.UK Frontend ≥5.0.0"
Screenshot 2023-12-18 at 10 53 22

@frankieroberto
Copy link
Contributor Author

@frankieroberto Not sure if your thumbs up is for the way to install the previous version or adding extra info to the name, please let me know which. I've quickly mocked up some extra info next to the name, if that's helpful:

  • "for GOV.UK Frontend >=5.0.0"

Done. It's a big ugly, but clarity beats aesthetics here, right?! 😄

@romaricpascal romaricpascal merged commit 925a522 into alphagov:main Dec 18, 2023
1 check passed
@frankieroberto frankieroberto deleted the add-task-list-pattern branch December 18, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants