Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datagovuk_publish from GitHub config #1592

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

AgaDufrat
Copy link
Contributor

@AgaDufrat AgaDufrat commented Jan 22, 2025

This repo was archived.

Manually removed artefact from the TF state.

Plan output

Screenshot 2025-01-22 at 16 07 18
  • changes to govuk-chat are expected
  • I can't remove aws_codecommit_repository.govuk_repos["alphagov/datagovuk_publish"] from TF state because I'm getting an error acquiring the state lock. Can't unlock in TF Cloud 🤷‍♀️ but I think it should be fine.

@AgaDufrat AgaDufrat changed the title Remove datagovuk_publish Remove datagovuk_publish from GitHub config Jan 22, 2025
@AgaDufrat AgaDufrat marked this pull request as draft January 22, 2025 14:39
@AgaDufrat AgaDufrat mentioned this pull request Jan 22, 2025
14 tasks
@AgaDufrat AgaDufrat self-assigned this Jan 22, 2025
@AgaDufrat AgaDufrat marked this pull request as ready for review January 22, 2025 15:35
This repo was archived
@AgaDufrat AgaDufrat requested a review from a team January 22, 2025 16:12
@kevindew
Copy link
Member

kevindew commented Jan 22, 2025

Looks good, can we also remove search-v2-infrastructure which has been archived (I think it was accidentally unarchived in the terraform process):

search-v2-infrastructure:
required_status_checks:
ignore_jenkins: true
additional_contexts:
- lint_and_validate

Edit: I've also learnt that search-v2-evaluator was recently archived and should be removed too (currently now in a non-archived state)

@AgaDufrat
Copy link
Contributor Author

AgaDufrat commented Jan 22, 2025

Looks good, can we also remove search-v2-infrastructure which has been archived (I think it was accidentally unarchived in the terraform process)

👍 It was flagged by one of our alerts. I'll do it in a separate PR.

Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@AgaDufrat AgaDufrat merged commit 2d279d6 into main Jan 22, 2025
1 check passed
@AgaDufrat AgaDufrat deleted the remove-dgu-publish branch January 22, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants