Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 48px favicon #986

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Add 48px favicon #986

merged 3 commits into from
Sep 21, 2018

Conversation

dashouse
Copy link

@dashouse dashouse commented Sep 7, 2018 •
edited by kr8n3r
Loading

Add a single favicon with multiple sizes
Fixes #963

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-986 September 7, 2018 09:37 Inactive
@36degrees

This comment has been minimized.

Sign in to view
@kr8n3r

This comment has been minimized.

Sign in to view
@kr8n3r kr8n3r changed the title DO NOT MERGE: Add 48px favicon Add 48px favicon Sep 18, 2018
@NickColley
Copy link
Contributor

@igloosi does it look different before and after?

@kr8n3r
Copy link

kr8n3r commented Sep 18, 2018 •
edited
Loading

marginally
screen shot 2018-09-18 at 11 27 41
screen shot 2018-09-18 at 11 29 55
screen shot 2018-09-18 at 11 31 31

but the checker passes 😉
https://realfavicongenerator.net/favicon_checker?protocol=https&site=govuk-frontend-review-pr-986.herokuapp.com%2Fexamples%2Ftemplate-default#.W6H9wf5Kh24
screen shot 2018-09-19 at 08 42 58

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-986 September 19, 2018 07:39 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-986 September 21, 2018 12:39 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-986 September 21, 2018 12:41 Inactive
igloosi added 2 commits September 21, 2018 13:47
Specify sizes for favicon
b61ca3c 
Single favicon contains 16x16, 32x32 and 48x48px versions.
Document in CHANGELOG
85ed6b6
@kr8n3r kr8n3r added this to the [NEXT] milestone Sep 21, 2018
@kr8n3r kr8n3r merged commit 526e752 into master Sep 21, 2018
@kr8n3r kr8n3r deleted the add-48px-favicon branch September 21, 2018 12:51
@36degrees 36degrees mentioned this pull request Sep 21, 2018
Merged
@kr8n3r kr8n3r mentioned this pull request Sep 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dashouse @36degrees @kr8n3r @NickColley @govuk-design-system-ci