Fix ‘backwards compatibility’ for the date input. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-908
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-908
alex-ju
approved these changes
Jul 16, 2018
The previous implementation meant that if your input _does not_ have the name ‘year’ it would always get the class ‘govuk-input--width-2`. Because this class is defined last [1] – after every other width class – this makes it impossible to make any field that does not have the name ‘year’ use any other width than 2 characters. This commit addresses this by: - not adding a width class if any other width class is present within the `item.classes` (it’s relatively a naive check for the string ‘govuk-input--width-‘ but it should do the job) - only adding appropriate classes if the input has the name ‘day’, ‘month’ or ‘year’ It also adds tests for this behaviour. Fixes #907 [1]: https://github.com/alphagov/govuk-frontend/blob/8f2fe567865729716fa4a04b0c6eeb5860da7441/src/components/input/_input.scss#L71-L73
36degrees
force-pushed
the
fix-date-input-backwards-compatibility
branch
from
ac86ff8 to
2ea133f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-908
NickColley
approved these changes
Jul 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation meant that if your input does not have the name ‘year’ it would always get the class ‘govuk-input--width-2`.
Because this class is defined last – after every other width class – this makes it impossible to make any field that does not have the name ‘year’ use any other width than 2 characters.
This addresses this by:
item.classes(it’s relatively a naive check for the string ‘govuk-input--width-‘ but it should do the job)It also adds tests for this behaviour.
Fixes #907