Update details behaviour to remove margin-bottom for all elements #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-900
If we have a form-group it will not be caught by the logic that only targets paragraphs. This is consistent with the tabs and conditional reveal logic.
NickColley
force-pushed
the
remove-margin-bottom-details-last-child
branch
from
1eb86eb to
c659e6b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-900
NickColley
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-900
NickColley
commented
Jul 13, 2018
src/components/details/_details.scss
Outdated
| @@ -75,12 +75,12 @@ | |||
| border-left: $govuk-border-width solid $govuk-border-colour; | |||
| } | |||
|
|
|||
| .govuk-details__text p { | |||
| .govuk-details__text > p { | |||
There was a problem hiding this comment.
Might be a breaking change actually 🤔
If the original feature was flakey, I'm not sure making it more robust is breaking.
I guess it is?
NickColley
force-pushed
the
remove-margin-bottom-details-last-child
branch
from
adf7691 to
ebb6d16
Compare
kr8n3r
approved these changes
Jul 16, 2018
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a form-group it will not be caught by the logic that only targets paragraphs.
This is consistent with the tabs and conditional reveal logic.
Fixes #899