Fix header component's reliance on markup whitespace #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`display: inline-block` is sensitive to whitespace, so if there are characters in between two divs that will be output when they are rendered. This means when columns are exactly 33.3% and 66.6% to sit alongside each other, the whitespace that is output misaligns the columns forcing them onto a new line. Using floats is similar to how our grid system works, but requires a clearfix on the parent container, so that the component does not collapse.
This also adds whitespace between the 'content' div and it's sibiling column, which is enabled by the work to make this CSS use floats instead of `display: inline-block`
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-884
NickColley
changed the title
alex-ju
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
Tested cross browser as part of alphagov/govuk_publishing_components#408
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display: inline-blockis sensitive to whitespace, so if there are characters in between two divsthat will be output when they are rendered.
This means when columns are exactly 33.3% and 66.6% to sit alongside each other,
the whitespace that is output misaligns the columns forcing them onto a new line.
Using floats is similar to how our grid system works, but requires a clearfix on the parent container,
so that the component does not collapse.
I have tested this cross browser and also did a before and after at different viewports to check the behaviour is consistent.
That said this change still makes me nervous, so appreciate reviewers scrutiny 😄
Fixes #828
https://trello.com/c/bKTTsJzo/1194-service-name-falls-below-govuk-in-header-when-there-is-whitespace-between-the-two-divs