Add govuk-visually-hidden-focusable class #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-859
alex-ju
force-pushed
the
fix-focusable-typo
branch
from
bb57578 to
0aef756
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-859
alex-ju
force-pushed
the
fix-focusable-typo
branch
from
0aef756 to
ecd2af1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-859
NickColley
reviewed
Jul 4, 2018
| .govuk-visually-hidden-focussable { | ||
| @include govuk-visually-hidden-focusable; | ||
| } | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
Tried, but Sass docs struggles with that when @ ing the deprecation
There was a problem hiding this comment.
Also I think by generally defining the deprecated code separately make it easier to remove on major releases. We're doing the same with the font baseline adjustments.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new class
.govuk-visually-hidden-focusableand deprecates.govuk-visually-hidden-focussable