-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update date input component #857
Conversation
b9cbf5d
to
8bcd22f
Compare
bfe1eaf
to
1d8d2fe
Compare
awesome work! 🎆 I wonder if input changes and date input changes could be separate PR's (dependency)? |
@igloosi: I didn't want to introduce dependencies between the PRs, but if that makes more sense I can split them up |
true, if we we're going breaking at some point should be fine, as this PR has both new features and breaking changes |
1d8d2fe
to
729619a
Compare
729619a
to
6abefcc
Compare
6abefcc
to
8b2a73e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top work !
8b2a73e
to
8ae2bce
Compare
8ae2bce
to
e3b87a2
Compare
This PR:
Extends the input width classes to cover 2 to 5 characters so it can be reused for the date-input component:
Updates the date-input component to:
Adds default date-input items if no items are being specified (fixes #468)
When users increase the font-size on labels
Before
After