Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date input component #857

Merged
merged 7 commits into from
Jul 6, 2018
Merged

Update date input component #857

merged 7 commits into from
Jul 6, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Jul 2, 2018

This PR:

Extends the input width classes to cover 2 to 5 characters so it can be reused for the date-input component:

  • defines a relationship between the number of characters and maximum ex width of an input
  • keeps the extra space for safari pre-fill icon on large inputs (10, 20, 30)

Updates the date-input component to:

Adds default date-input items if no items are being specified (fixes #468)

input-width

date-input-examples

When users increase the font-size on labels

Before
screen shot 2018-07-04 at 12 14 55

After
screen shot 2018-07-04 at 12 15 17

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 2, 2018 12:19 Inactive
@alex-ju alex-ju force-pushed the update-date-input-component branch from b9cbf5d to 8bcd22f Compare July 2, 2018 12:53
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 2, 2018 12:53 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 2, 2018 13:41 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 2, 2018 14:33 Inactive
@alex-ju alex-ju force-pushed the update-date-input-component branch from bfe1eaf to 1d8d2fe Compare July 2, 2018 14:35
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 2, 2018 14:36 Inactive
@kr8n3r
Copy link

kr8n3r commented Jul 2, 2018

awesome work! 🎆

I wonder if input changes and date input changes could be separate PR's (dependency)?

@alex-ju
Copy link
Contributor Author

alex-ju commented Jul 2, 2018

@igloosi: I didn't want to introduce dependencies between the PRs, but if that makes more sense I can split them up

@kr8n3r
Copy link

kr8n3r commented Jul 3, 2018

true, if we we're going breaking at some point should be fine, as this PR has both new features and breaking changes

@alex-ju alex-ju force-pushed the update-date-input-component branch from 1d8d2fe to 729619a Compare July 4, 2018 11:25
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 4, 2018 11:26 Inactive
@alex-ju alex-ju added this to the v1.1.0 milestone Jul 4, 2018
@alex-ju alex-ju force-pushed the update-date-input-component branch from 729619a to 6abefcc Compare July 4, 2018 11:38
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 4, 2018 11:38 Inactive
@alex-ju alex-ju force-pushed the update-date-input-component branch from 6abefcc to 8b2a73e Compare July 4, 2018 12:51
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 4, 2018 12:51 Inactive
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top work !

@alex-ju alex-ju force-pushed the update-date-input-component branch from 8b2a73e to 8ae2bce Compare July 6, 2018 11:28
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-857 July 6, 2018 11:28 Inactive
@alex-ju alex-ju force-pushed the update-date-input-component branch from 8ae2bce to e3b87a2 Compare July 6, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date input macro styling breaks if item name is changed govukDateInput macro could have default items
3 participants