Reduce margin-bottom on the hint when following a default or small label #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with this but am not going to review it as I paired with Dave to come up with the solution. |
|
Merged, thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
margin-bottomof the hint component is the same for all label sizes.For the default (no class) or
govuk-label--sclass this looks unbalanced.This PR reduces the margin-bottom of the hint by 5px after a default
<label>or<label class="govuk-label--s">.Before
After
This does not affect the hint when used with a legend (original spacing is fine) or when the
<label>is inside an<h1>(isPageHeading: True) - however I'm ok with this because the default /govuk-label--swill never be used in this scenario.