-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update components' tables of arguments #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 14:42
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 6, 2018 14:47
243bce9
to
ee31937
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 14:47
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 6, 2018 14:53
ee31937
to
6aae8fd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 14:53
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 6, 2018 15:13
6aae8fd
to
fb1dd7c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 15:14
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 15:30
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 6, 2018 15:35
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 7, 2018 07:57
4aed4b3
to
469ffdc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 7, 2018 07:57
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 7, 2018 08:10
469ffdc
to
51c2cb7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 7, 2018 08:10
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 7, 2018 08:26
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 8, 2018 13:26
a410106
to
ec469bf
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 8, 2018 13:27
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 8, 2018 13:51
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 8, 2018 15:30
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 8, 2018 15:34
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 08:27
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 11, 2018 08:35
4e55d17
to
84a4a90
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 08:35
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 08:41
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 08:46
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 08:55
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 12:39
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 13:02
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 11, 2018 13:37
dfb0200
to
52c39f1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 11, 2018 13:37
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-769
June 12, 2018 08:07
Inactive
kr8n3r
force-pushed
the
update-tables-of-arguments
branch
from
June 13, 2018 15:35
fae135e
to
6d2fc39
Compare
hannalaakso
approved these changes
Jun 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🎉
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring table of arguments for each components is accurate.
Updates to
index.njk
andREADME.md
files for each component.Trello ticket: https://trello.com/c/rRQl78KY/1038-make-sure-all-component-argument-tables-are-accurate
For reviewers: Might be easiest to go through each component page on Github in the branch to check the rendered README file.