Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check if sass in packages compiles when copied over #669

Merged
merged 2 commits into from
Apr 23, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Apr 20, 2018

As part of the recommendation from the Incident review.

Expanding the current test after building packages to check if Sass compiles.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-669 April 20, 2018 11:02 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-669 April 20, 2018 12:19 Inactive
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested, looks good to me

@kr8n3r kr8n3r merged commit 41e8d7c into master Apr 23, 2018
@alex-ju alex-ju deleted the test-to-compile-packages-sass branch April 23, 2018 14:58
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants