Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing docs #651

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Update publishing docs #651

merged 2 commits into from
Apr 12, 2018

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Apr 12, 2018

This PR:

  • Updates publishing docs.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-651 April 12, 2018 12:47 Inactive
@hannalaakso hannalaakso force-pushed the update-docs-for-publish branch from 33428b2 to 0734c14 Compare April 12, 2018 12:48
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-651 April 12, 2018 12:48 Inactive
- add [vendor prefixes](https://github.com/postcss/autoprefixer) to CSS in `packages/`
- build "all" Sass and JavaScript files into `dist/`
- copy components from `src/` to `dist/components/` and run tests
This will:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is broken when rendered

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test it? I'm using Markdown Preview in Atom and it looks okay in that.

Copy link

@kr8n3r kr8n3r Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look now @igloosi

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-651 April 12, 2018 13:09 Inactive
@hannalaakso hannalaakso force-pushed the update-docs-for-publish branch from 167dcd5 to d99f81b Compare April 12, 2018 13:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-651 April 12, 2018 13:13 Inactive
@hannalaakso hannalaakso merged commit 1affb48 into master Apr 12, 2018
@hannalaakso hannalaakso deleted the update-docs-for-publish branch April 12, 2018 14:08
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants