Remove redundant font-family rule in button #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-650
kr8n3r
requested changes
Apr 12, 2018
|
Yep, but can't do that until #648 is merged! |
|
Release 0.0.27 is out 💥 |
hannalaakso
approved these changes
Apr 12, 2018
Remove explicit font-family definition from the button scss. We don't need it because we get it as part of the included `govuk-font-regular` mixin which defines the font for us. This will remove a redundant duplicated font-family rule and also mean that the button will correctly fall back to the print font when printed.
kr8n3r
approved these changes
Apr 12, 2018
36degrees
force-pushed
the
remove-font-family-from-button
branch
from
32bab4d to
3be1344
Compare
|
Rebased and documented in changelog. |
kr8n3r
approved these changes
Apr 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit font-family definition from the button scss. We don't need it because we get it as part of the included
govuk-font-regularmixin which defines the font for us.This will remove a redundant duplicated font-family rule and also mean that the button will correctly fall back to the print font when printed.
Hat tip to @dashouse for spotting this 👀