Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.0.25-alpha #582

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Release v0.0.25-alpha #582

merged 1 commit into from
Mar 7, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Mar 6, 2018

0.0.25-alpha (Breaking release)

πŸ’₯ Breaking changes:

  • The colour variable $govuk-fuschia has been replaced with a new variable
    with the correct spelling ($govuk-fuchsia) – thanks to
    @charlesrt for reporting.
    (PR #571)

πŸ†• New features:

  • The input macro now accepts a type which allows you to override the default
    type="text" (PR #568)

πŸ”§ Fixes:

  • The transparent outline has been removed from the button, as it already has
    a transparent border which is visible when overriding colours in the browser
    (PR #552)
  • Redundant duplication on the start button variant has been removed as it is
    inherited from the main .govuk-c-button class
    (PR #552)
  • A fix to remove a black border from buttons in IE7 has been removed as we are
    not targeting IE7 for GOV.UK Frontend
    (PR #552)
  • The date input component now sets type="number" and pattern="[0-9]*" to
    match the previous implementation in Elements
    (PR #568)

🏠 Internal:

  • The logic to determine button text colour automatically has been removed and
    replaced with a new variable $govuk-button-text-colour
    (PR #552)
  • The button component now uses the focusable mixin
    (PR #552)
  • The button component Sass has been restructured so that e.g. pseudo-selectors
    are consistently nested within their parents
    (PR #552)
  • Fixes for the release process
    (PR #567)
  • Add HTML5-shiv to review app
    (PR #575)

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@kr8n3r kr8n3r merged commit aa14b25 into master Mar 7, 2018
@kr8n3r kr8n3r deleted the release-v0.0.25-alpha branch March 7, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants