Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.0.25-alpha #580

Closed
wants to merge 1 commit into from
Closed

Release v0.0.25-alpha #580

wants to merge 1 commit into from

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Mar 6, 2018

0.0.25-alpha (Breaking release)

πŸ’₯ Breaking changes:

  • The colour variable $govuk-fuschia has been replaced with a new variable
    with the correct spelling ($govuk-fuchsia) – thanks to
    @charlesrt for reporting.
    (PR #571)

πŸ”§ Fixes:

  • The transparent outline has been removed from the button, as it already has
    a transparent border which is visible when overriding colours in the browser
    (PR #552)
  • Redundant duplication on the start button variant has been removed as it is
    inherited from the main .govuk-c-button class
    (PR #552)
  • A fix to remove a black border from buttons in IE7 has been removed as we are
    not targeting IE7 for GOV.UK Frontend
    (PR #552)

🏠 Internal:

  • The logic to determine button text colour automatically has been removed and
    replaced with a new variable $govuk-button-text-colour
    (PR #552)
  • The button component now uses the focusable mixin
    (PR #552)
  • The button component Sass has been restructured so that e.g. pseudo-selectors
    are consistently nested within their parents
    (PR #552)
  • Fixes for the release process
    (PR #567)
  • Add HTML5-shiv to review app
    (PR #575)

@36degrees
Copy link
Contributor

Argh, sorry @igloosi – #581 should definitely be part of this release too.

@36degrees
Copy link
Contributor

Happy for you to cherry pick that commit into this PR if that's easier.

@kr8n3r
Copy link
Author

kr8n3r commented Mar 6, 2018

that's fine. i'll close this and rerun with your changes

@kr8n3r kr8n3r closed this Mar 6, 2018
@kr8n3r kr8n3r deleted the release-0.0.25 branch March 6, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants