-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button shim and setup Puppeteer #572
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
613d751
Add button shim from govuk_frontend_toolkit
alex-ju 2e42674
Rewrite in plain JavaScript
alex-ju f04d0c1
Update using common polyfill functions
alex-ju 0338f95
Listen to keydown at the document level
alex-ju 1bc68cf
Setup puppeteer
alex-ju 3119acd
Add button test
alex-ju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
const chalk = require('chalk') | ||
const NodeEnvironment = require('jest-environment-node') | ||
const puppeteer = require('puppeteer') | ||
const fs = require('fs') | ||
const os = require('os') | ||
const path = require('path') | ||
|
||
const DIR = path.join(os.tmpdir(), 'jest-puppeteer-global-setup') | ||
|
||
class PuppeteerEnvironment extends NodeEnvironment { | ||
async setup () { | ||
console.log(chalk.yellow('Setup Test Environment.')) | ||
await super.setup() | ||
const wsEndpoint = fs.readFileSync(path.join(DIR, 'wsEndpoint'), 'utf8') | ||
if (!wsEndpoint) { | ||
throw new Error('wsEndpoint not found') | ||
} | ||
this.global.__BROWSER__ = await puppeteer.connect({ | ||
browserWSEndpoint: wsEndpoint | ||
}) | ||
} | ||
|
||
async teardown () { | ||
console.log(chalk.yellow('Teardown Test Environment.')) | ||
await super.teardown() | ||
} | ||
|
||
runScript (script) { | ||
return super.runScript(script) | ||
} | ||
} | ||
|
||
module.exports = PuppeteerEnvironment |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
const chalk = require('chalk') | ||
const puppeteer = require('puppeteer') | ||
const fs = require('fs') | ||
const mkdirp = require('mkdirp') | ||
const os = require('os') | ||
const path = require('path') | ||
const app = require('../../app/app.js') | ||
|
||
const DIR = path.join(os.tmpdir(), 'jest-puppeteer-global-setup') | ||
|
||
module.exports = async function () { | ||
console.log(chalk.green('\nStart server')) | ||
global.__SERVER__ = app.listen(3000) | ||
console.log(chalk.green('Setup Puppeteer'))// | ||
// we use --no-sandbox --disable-setuid-sandbox as a workaround for the | ||
// 'No usable sandbox! Update your kernel' error | ||
// see more https://github.com/Googlechrome/puppeteer/issues/290 | ||
const browser = await puppeteer.launch({args: ['--no-sandbox', '--disable-setuid-sandbox']}) | ||
global.__BROWSER__ = browser | ||
mkdirp.sync(DIR) | ||
fs.writeFileSync(path.join(DIR, 'wsEndpoint'), browser.wsEndpoint()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
const chalk = require('chalk') | ||
const rimraf = require('rimraf') | ||
const os = require('os') | ||
const path = require('path') | ||
|
||
const DIR = path.join(os.tmpdir(), 'jest-puppeteer-global-setup') | ||
|
||
module.exports = async function () { | ||
console.log(chalk.green('Teardown Puppeteer')) | ||
await global.__BROWSER__.close() | ||
console.log(chalk.green('Close server')) | ||
await global.__SERVER__.close() | ||
rimraf.sync(DIR) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we document why we need to use
--forceExit
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is 'documented' on line 24. would be good to look into is and see if we can make it work without
--forceExit
, but maybe not part of this PR