Namespace all @functions and @mixin's #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-557
36degrees
reviewed
Feb 28, 2018
src/globals/scss/helpers/_arrow.scss
Outdated
| $square-root-of-three: 1.732; | ||
|
|
||
| @return ($base / 2) * $square-root-of-three; | ||
| } | ||
|
|
||
| // Arrow mixin | ||
| // govuk-shape-arrow mixin |
There was a problem hiding this comment.
Overly keen find and replacing throughout this doc block? 🙂
src/globals/scss/helpers/_arrow.scss
Outdated
| @@ -58,6 +58,6 @@ | |||
| border-width: $perpendicular $height $perpendicular 0; | |||
| border-right-color: currentColor; // 2 | |||
| } @else { | |||
| @error "Invalid arrow direction: expected `up`, `right`, `down` or `left`, got `#{$direction}`"; | |||
| @error "Invalid govuk-shape-arrow direction: expected `up`, `right`, `down` or `left`, got `#{$direction}`"; | |||
There was a problem hiding this comment.
Overly keen find and replacing here too.
src/globals/scss/tools/_iff.scss
Outdated
| @@ -1,5 +1,5 @@ | |||
| // Wrapper for Sass' built-in `if` function that does not require you to pass | |||
| // a value for $if-false. | |||
| @function iff($condition, $if-true) { | |||
| @function govuk-iff($condition, $if-true) { | |||
There was a problem hiding this comment.
I wonder if this function is worth keeping given the intention was to have a shorter way of writing
if($important, !important, null)
and now this is:
govuk-iff($important, !important)
Happy to address this in a later PR though.
src/globals/scss/helpers/_arrow.scss
Outdated
| // @param {Base} $base - Length of the triangle 'base' side | ||
| // @param {Height} $height - Height of triangle. Omit for equilateral. | ||
| @mixin arrow($direction, $base, $height: null) { | ||
| @mixin govuk-shape-arrow($direction, $base, $height: null) { |
There was a problem hiding this comment.
If we're going to change the name of this to shape-arrow then can we update the filename to _shape-arrow.scss too please?
added 2 commits
February 28, 2018 09:33
To avoid breaking compilation when Frontend is imported into an existign app that uses custom functions or GOV.UK Elements or GOV.UK Frontend toolkit
kr8n3r
force-pushed
the
namespace-mixins-and-functions
branch
from
3f4cc21 to
4768eee
Compare
|
updated |
|
Looks good to me too (meant to say that this morning) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid breaking compilation when Frontend is imported into an existing app that uses custom
functions or GOV.UK Elements or GOV.UK Frontend toolkit, as observed in user research.
May have gone a bit too far in namespacing all the things, but we can remove some.
Trello ticket: https://trello.com/c/B2tdqPg5/784-fix-em-function-conflict-with-govuk-elements