Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use govuk-text-colour mixin for fieldset #544

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Use govuk-text-colour mixin for fieldset #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

Note: We're not following semantic versioning yet, we are going to talk about this soon.

## Unreleased

Fixes:

- Fieldset legends now correctly use 'full black' text colour when printed
(PR [#544](https://github.com/alphagov/govuk-frontend/pull/544)

## 0.0.23-alpha (Breaking release)

Breaking changes:
Expand Down
2 changes: 1 addition & 1 deletion src/components/fieldset/_fieldset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

.govuk-c-fieldset__legend {
@include govuk-font-regular-19;
@include govuk-text-colour;

// Fix legend text wrapping in Edge and IE
// 1. IE9-11 & Edge 12-13
Expand All @@ -22,7 +23,6 @@
// Hack to let legends or elements within legends have margins in webkit browsers
overflow: hidden;

color: $govuk-text-colour;
white-space: normal; // 1

.govuk-heading-s {
Expand Down