Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate File upload component's value parameter #5330

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Deprecate File upload component's value parameter #5330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ For advice on how to use these release notes see [our guidance on staying up to

## Unreleased

### Recommended changes

#### Stop setting a `value` for File upload components

The File upload component currently supports a `value` parameter, which populates the `value` HTML attribute of the input.

However, since no modern browser supports passing a `value` to a file input, we've made the decision to remove this parameter. It has been deprecated and will be removed in a future version of GOV.UK Frontend.

We introduced this change in [pull request #5330: Deprecate File upload component's `value` parameter](https://github.com/alphagov/govuk-frontend/pull/5330).

### Fixes

We've made fixes to GOV.UK Frontend in the following pull requests:
Expand Down
2 changes: 1 addition & 1 deletion packages/govuk-frontend/src/govuk/components/file-upload/file-upload.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ params:
- name: value
type: string
required: false
description: Optional initial value of the input.
description: Deprecated. Optional initial value of the input.
- name: disabled
type: boolean
required: false
Expand Down