Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Enable Rollup ES2015 helper code #4555

Closed
wants to merge 2 commits into from
Closed

Conversation

colinrotherham
Copy link
Contributor

We forgot to enable Rollup generatedCode: 'es2015' now we use ES modules for govuk-frontend.min.js

Adding this config change to see what the diff looks like

Builds on top of #4537

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4555 December 11, 2023 15:02 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.72 KiB
dist/govuk-frontend-development.min.js 38.54 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.37 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.58 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.7 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.53 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 69.9 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.09 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 3.9 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.3 KiB
components/tabs/tabs.mjs 9.66 KiB

View stats and visualisations on the review app


Action run for 6d39d88

Copy link

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/all.bundle.js b/packages/govuk-frontend/dist/govuk/all.bundle.js
index 41ece10c0..6468a47c4 100644
--- a/packages/govuk-frontend/dist/govuk/all.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/all.bundle.js
@@ -2153,5 +2153,7 @@
   exports.initAll = initAll;
   exports.version = version;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=all.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
index d5dca973f..6f58999aa 100644
--- a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
@@ -671,5 +671,7 @@
 
   exports.Accordion = Accordion;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=accordion.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
index 5491951c7..e784c63be 100644
--- a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
@@ -190,5 +190,7 @@
 
   exports.Button = Button;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=button.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
index 482acde8d..2e5cd5ff8 100644
--- a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
@@ -635,5 +635,7 @@
 
   exports.CharacterCount = CharacterCount;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=character-count.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
index cd1ad83e7..32d6abb71 100644
--- a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
@@ -190,5 +190,7 @@
 
   exports.Checkboxes = Checkboxes;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=checkboxes.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
index 52ac02840..9d45c0d8d 100644
--- a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
@@ -233,5 +233,7 @@
 
   exports.ErrorSummary = ErrorSummary;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=error-summary.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
index 5f4fde08a..566254cd0 100644
--- a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
@@ -541,5 +541,7 @@
 
   exports.ExitThisPage = ExitThisPage;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=exit-this-page.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
index 89d981d4d..565183861 100644
--- a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
@@ -156,5 +156,7 @@
 
   exports.Header = Header;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=header.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
index d1d0de998..464b9790a 100644
--- a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
@@ -180,5 +180,7 @@
 
   exports.NotificationBanner = NotificationBanner;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=notification-banner.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
index 11cb7cbe4..d77cd527f 100644
--- a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
@@ -167,5 +167,7 @@
 
   exports.Radios = Radios;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=radios.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
index 8489f8501..60a1ff278 100644
--- a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
@@ -158,5 +158,7 @@
 
   exports.SkipLink = SkipLink;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=skip-link.bundle.js.map
diff --git a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
index af2dde6c2..e035ddc8c 100644
--- a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
@@ -366,5 +366,7 @@
 
   exports.Tabs = Tabs;
 
+  Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+
 }));
 //# sourceMappingURL=tabs.bundle.js.map

Action run for 6d39d88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants