Add ‘no visited state' link variant #446
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-446
src/globals/scss/core/_links.scss
Outdated
| // dashboards. The content on the page is changing all the time, so the fact | ||
| // that you’ve visited it before is not important. | ||
| .govuk-link--unvisited { | ||
| &:visited { |
There was a problem hiding this comment.
Can we leave this unnested?
There was a problem hiding this comment.
We can, though I think there is some value in being consistent with the way the rest of the file is written, making it easier to scan. I also personally think it'd be easy to miss if it was on the same line as the class name.
There was a problem hiding this comment.
Ah sorry, I didn't see the rest of the file in this diff.
Sounds good to me 👍
Add an ‘no visited state' link variant which can be used where it is not helpful to distinguish between visited and non-visited links. For example, navigation links to pages with dynamic content like admin dashboards. The content on the page is changing all the time, so the fact that you’ve visited it before is not important. Closes #297
36degrees
force-pushed
the
add-unvisited-link-variant
branch
from
e175475 to
1cd70ff
Compare
36degrees
changed the title
|
@NickColley have changed to |
|
@36degrees makes sense to me, a bit verbose but hopefully very clear 👍 |
|
Mind approving again? I dismissed your previous review. |
govuk-design-system-ci
had a problem deploying
to
govuk-frontend-review-pr-446
|
@NickColley Good shout. Done 👍 |
Add an ‘no visited state' link variant which can be used where it is not helpful to distinguish between visited and non-visited links.
For example, navigation links to pages with dynamic content like admin dashboards. The content on the page is changing all the time, so the fact that you’ve visited it before is not important.
Closes #297
https://trello.com/c/BF3hYuXJ/622-add-link-variant-for-links-with-no-visited-state