Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Tudor crown in the Header component (v4.x) #4278

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

querkmachine
Copy link
Member

@querkmachine querkmachine commented Sep 29, 2023

Implement the Tudor crown iconography in the Header component. Part of #4179.

See #4297 for the equivalent changes for Frontend v5.

Warning

This PR should not be merged until we have approval to do so.

Changes

  • Adds the Tudor crown SVG to the Header component.
    • Both crowns (and their fallbacks) have been moved out into their own private variables to try and keep the bulk of the HTML easy to read.
  • Adds a new Tudor crown fallback graphic for IE8.
  • Adds a new Nunjucks parameter to the Header component, useTudorCrown, to switch to using the new Tudor crown.
  • Adds some styles adjusting the positioning of the Tudor crown, if it's in use.
  • Adds tests ensuring that the Tudor crown is being rendered if the flag is set, and repeats the same tests carried out for the St. Edward's crown.

Todo

  • When complete, this PR can (probably) be wholesale copied for v3.x with little to no alteration.

@querkmachine querkmachine self-assigned this Sep 29, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4278 September 29, 2023 15:51 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4278 September 29, 2023 16:15 Inactive
@querkmachine querkmachine requested a review from a team October 6, 2023 07:55
@querkmachine querkmachine changed the title Implement the Tudor crown in the Header component (v4.x) [DO NOT MERGE] Implement the Tudor crown in the Header component (v4.x) Oct 19, 2023
@querkmachine querkmachine marked this pull request as ready for review October 19, 2023 08:56
@querkmachine querkmachine linked an issue Oct 30, 2023 that may be closed by this pull request
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I ummed and ahhed about the width="32" targeting over using a modifier class but it's probably the simplest way to do it considering we'd ask users to change that value anyway, and IMO the impact of a user missing setting width to 32 if they're not using our macros is pretty low.

We should be explicit in our release notes that users not using our macro should set the width when updating the svg, or ideally just re-copy a new svg.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4278 November 30, 2023 15:19 Inactive
@querkmachine querkmachine changed the title [DO NOT MERGE] Implement the Tudor crown in the Header component (v4.x) Implement the Tudor crown in the Header component (v4.x) Jan 4, 2024
@querkmachine
Copy link
Member Author

Merging in preparation for release w/c 15th January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the new crown assets in Frontend (v4)
3 participants