Throw ElementError (not found) if checkboxes or radios have no input items

[domoscargin]

Closes #4131

[github-actions]

📋 Stats

File sizes

File	Size
dist/govuk-frontend-4.6.0.min.css	118.07 KiB
dist/govuk-frontend-4.6.0.min.js	47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css	79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js	76.42 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs	71.79 KiB
packages/govuk-frontend/dist/govuk/all.mjs	3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs	359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js	37.16 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs	5.83 KiB

Modules

File	Size
all.mjs	67.89 KiB
components/accordion/accordion.mjs	21.9 KiB
components/button/button.mjs	4.71 KiB
components/character-count/character-count.mjs	21.64 KiB
components/checkboxes/checkboxes.mjs	5.69 KiB
components/error-summary/error-summary.mjs	6.01 KiB
components/exit-this-page/exit-this-page.mjs	16.6 KiB
components/header/header.mjs	3.34 KiB
components/notification-banner/notification-banner.mjs	4.54 KiB
components/radios/radios.mjs	4.68 KiB
components/skip-link/skip-link.mjs	3.73 KiB
components/tabs/tabs.mjs	9.07 KiB

View stats and visualisations on the review app

---

Action run for 48903c5

[domoscargin]

Suspect we also want to throw an error here, for the case where the element with targetId is not found, but not for the case where the input has no data-aria-controls attribute.

govuk-frontend/packages/govuk-frontend/src/govuk/components/checkboxes/checkboxes.mjs

Lines 56 to 60 in df9c59a

	// Skip checkboxes without data-aria-controls attributes, or where the
	// target element does not exist.
	if (!targetId || !document.getElementById(targetId)) {
	return
	}

[colinrotherham]

Am I allowed to approve it yet??

[domoscargin]

Am I allowed to approve it yet??

Haha, I'm just looking at the stuff in my comment - which wouldn't be caused by a user-created parameter, except I guess in the case where they're using HTML and make a mistake.

[domoscargin]

@colinrotherham Should hopefully be good for review now.

[domoscargin]

We create item and conditional IDs internally in the template:

govuk-frontend/packages/govuk-frontend/src/govuk/components/checkboxes/template.njk

Line 62 in 704cf6d

{% set conditionalId = "conditional-" + id %}

However, this check is still useful for folks using HTML instead of the Nunjucks macros, as they'd be inputting their own data-aria-controls and ids.

[colinrotherham]

I like how this is clearer, but realised we only select by ID?

Suggested change

	identifier: `.govuk-checkboxes__conditional #${targetId}`
	identifier: `#${targetId}`

[colinrotherham]

I do prefer CSS selectors though, see https://github.com/alphagov/govuk-frontend/pull/4236/files#r1331775855

[domoscargin]

I'm happy to revert this for this PR, but something to discuss when we review the content - is targetId user-friendly enough when there may be some kind of issue with it? Ideally having the parent radios item info in there would be great, but realise I may be going too far.

[colinrotherham]

Did some digging, and we used to scope it to $module before 266f877

I suppose since then the target could genuinely be anywhere on the page?

E.g. Tick a box in a left column and a question is revealed on the right?