Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support/4.x] Backport: Run GitHub Actions tests on Windows #3993

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Jul 21, 2023

This is a port of @colinrotherham's changes in #3955 to the support/4.x branch.

It's currently not possible to merge pull requests based off of the support/4.x branch (like #3990) because the Windows tests are set up as required status checks but GitHub Actions is not configured to run them.


This PR updates our GitHub Actions tests to run on both Ubuntu and Windows:

Only Ubuntu runs Percy screenshots and Node.js package export tests

Branch protection status checks will need updating to include the runner

Update 1: Thankfully looks like GitHub ignores the (${{ matrix.runner }}) at the end of the status check name

Update 2: Unfortunately re-running the checks now shows status check renames will be needed

@36degrees 36degrees requested a review from a team as a code owner July 21, 2023 08:40
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 21, 2023 08:40 Inactive
@36degrees 36degrees force-pushed the tests-on-windows-4.x branch from 62021c8 to 8c81b10 Compare July 21, 2023 08:50
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 21, 2023 08:50 Inactive
@colinrotherham
Copy link
Contributor

Maybe need #3584 too?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 24, 2023 15:01 Inactive
@colinrotherham colinrotherham changed the base branch from support/4.x to backport-fix-helpers-windows July 24, 2023 15:01
@colinrotherham colinrotherham force-pushed the backport-fix-helpers-windows branch from afc81a9 to c49196d Compare July 24, 2023 15:52
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 24, 2023 15:53 Inactive
@colinrotherham colinrotherham force-pushed the backport-fix-helpers-windows branch from c49196d to 7c85d71 Compare July 24, 2023 16:41
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 24, 2023 16:44 Inactive
@colinrotherham colinrotherham force-pushed the backport-fix-helpers-windows branch from 7c85d71 to f4c451c Compare July 24, 2023 17:02
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 24, 2023 17:06 Inactive
@36degrees
Copy link
Contributor Author

@colinrotherham thanks for looking into those and for rebasing this for me 🙌🏻

@colinrotherham
Copy link
Contributor

One more PR to go and this one's ready to go:

@colinrotherham colinrotherham force-pushed the backport-fix-helpers-windows branch from f4c451c to 012c3e6 Compare July 27, 2023 08:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 27, 2023 08:33 Inactive
@colinrotherham colinrotherham changed the title [support/4.x] Run GitHub Actions tests on Windows [support/4.x] Backport: Run GitHub Actions tests on Windows Jul 27, 2023
Base automatically changed from backport-fix-helpers-windows to support/4.x July 28, 2023 09:15
Preparation for the Tests workflow always running on Ubuntu and Windows
(cherry picked from commit 46254e9)
Windows is excluded from Percy and package export tests
(cherry picked from commit 6b531f6)
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3993 July 28, 2023 09:34 Inactive
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once the checks pass 😊

@colinrotherham colinrotherham merged commit adbb922 into support/4.x Jul 28, 2023
@colinrotherham colinrotherham deleted the tests-on-windows-4.x branch July 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants