Fix helpers getListing() and getDirectories() on Windows etc
#3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
added
🐛 bug
Rollup writes POSIX line endings on Windows causing tests to fail
colinrotherham
force-pushed
the
github-actions-windows
branch
from
6f09e8a to
4986804
Compare
We see failures due to Express.js startup delays, awaiting selector visibility, and accessibility tests taking 60+ seconds to loop through all component examples
Required for `workflow_call` calls but still works with `workflow_dispatch`
We previously let these Jest projects run early: 1. JavaScript unit tests 2. Nunjucks macro tests But they both finish sooner than the “Accessibility tests” project
All the cache keys have also been changed to ensure all archives are recreated
Unlike on Linux, tests run slower when concurrent due to the number of open Chrome windows/tabs
colinrotherham
force-pushed
the
github-actions-windows
branch
from
4986804 to
87e4b2c
Compare
romaricpascal
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Cheers for fixing our Windows tests 🙌🏻 Looks all good (albeit so painful to wait so long for results 🤣 )
We already skip package tests as we have coverage in our PR tests already
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes for places we've assumed Windows line endings and slashes were supported but weren't:
glob()patternPlus some timeout and speed fixes for GitHub Actions on Windows
Update: Linking to some Windows runs to confirm it works: