-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] DAC accessibility examples #3503
Conversation
Think this is more consistent with how the Summary List component works.
Pending outcome of review of Tag display
The IDs were initially hardcoded, but are now dynamic, to avoid having duplicate IDs.
Whilst some existing components use rows and others use items, 'items' is more generic, and is closer to the HTML tag name ("list item") and the class name (`govuk-task-list__item`).
…k-frontend into task-list-component
Think this can be smaller, in line with the existing Task List components in use in the wild.
e6629eb
to
1e40339
Compare
1e40339
to
ceb1a31
Compare
…gov/govuk-frontend into DAC-accessibility-examples
ceb1a31
to
3b7d07c
Compare
Some more suggestions for consistency:
|
Tweak some classes for consistency with the versions in the Design System documentation
Closing as we're done with DAC auditing for the mo |
Reopening as we are gearing up for a retest. Here is a spreadsheet of the results from the last audit. It contains reference to which examples need to change for retest (column L, type: Example and Prototype fix). We need to add or change these examples to include:
Examples that don't need to be retested:
'Other' examples that don't need to be retested: |
Examples that are different between this pull request and one of the latest pull requests of the review app #5046
|
Retests were done against a new PR: #5088. I think this one is safe to close off again now. |
This is an example of what we want to have in the Frontend Review App to take to the Digital Accessibility Centre for an Audit.
This pull request is not intended to be merged into
main
We need to add examples for:
We need to improve the full-page-examples page to include the other examples and a scenario for each if applicable.
For reviewers
Areas that explicitly need a review:
General review
Content and design review
Code review