Correct the closing double quotes in pagination Nunjucks #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Great spot @JoPintoPaul! This just needs a 2nd review before we can merge.
querkmachine
approved these changes
Jan 11, 2023
@querkmachine Would you like me to update the changelog on this PR, or will you folks do that? |
|
@JoPintoPaul Either you can update the PR yourself or we can add the changelog entry, if you'd prefer. |
… updated CHANGELOG
|
@querkmachine Updated PR with entry in CHANGELOG. |
owenatgov
reviewed
Jan 11, 2023
|
Please go ahead and make the change Owen, I will leave this with you.
…On Wed, 11 Jan 2023, 16:58 Owen Jones, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#3156 (comment)>
:
> @@ -2,6 +2,8 @@
## Unreleased
+- [Correcting incorrect closing double quotes in pagination Nunjucks](#3156)
Massive nitpick but we try to put fixes under the '## Fixes` heading
below. Would you mind moving this to a new line under line 30? Happy to do
this for you if you prefer.
—
Reply to this email directly, view it on GitHub
<#3156 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMT7VK2HSUNQMCBVYJ7ZUTWR3RDNANCNFSM6AAAAAATYELMG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
owenatgov
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted an incorrectly placed closing double quote in the template for the new Pagination component.