Fix focus styles for links split over multiple lines in Chromium 108+ (Chrome 108+, Edge 108+, Opera 94+) #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium 108 includes a change in behaviour for box decoration when a box is split over multiple lines, pages etc [1]. This change in theory brings Chromium in line with the CSS Fragmentation Module Level 3 spec [2] but means that the box-shadow (which we rely on for colour contrast for the focus state) no longer appears on links that break over multiple lines. This affects browsers based on Chromium 108 including Chrome 108, Edge 108 and Opera 94. Add `box-decoration-break: clone` so that `box-shadow` is applied to each fragment independently, maintaining the existing behaviour in Chromium browsers. [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=682173 [2]: https://www.w3.org/TR/css-break-3/#propdef-box-decoration-break Co-authored-by: Colin Rotherham <work@colinr.com>
colinrotherham
approved these changes
Dec 9, 2022
36degrees
changed the title
36degrees
changed the title
|
Wow, ridiculously quick turn around! Bravo! |
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium 108 includes a change in behaviour for box decoration when a box is split over multiple lines, pages etc.
This change in theory brings Chromium in line with the CSS Fragmentation Module Level 3 spec but means that the box-shadow (which we rely on for colour contrast for the focus state) no longer appears on links that break over multiple lines.
This affects browsers based on Chromium 108 including Chrome 108, Edge 108 and Opera 94.
Add
box-decoration-break: cloneso thatbox-shadowis applied to each fragment independently, maintaining the existing behaviour in Chromium browsers.Before
After
Fixes #3085.