Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for component's configuration #2928

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

romaricpascal
Copy link
Member

The entry covers multiple PRs and was missed when implementing the feature.

Closes #2885

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 18, 2022 14:03 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 18, 2022 14:07 Inactive
@romaricpascal romaricpascal marked this pull request as ready for review October 18, 2022 14:09
@romaricpascal romaricpascal requested review from claireashworth and a team October 18, 2022 14:09
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 18, 2022 14:45 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 19, 2022 08:32 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 20, 2022 13:57 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 20, 2022 14:01 Inactive
Entry covers multiple PRs and was missed when implementing the feature

Closes  #2885
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 20, 2022 14:07 Inactive
@romaricpascal
Copy link
Member Author

It should be all tidied up now (here's a link to the preview which is a bit nicer on the eye than the markdown).

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: CAAshworth <claire.ashworth@digital.cabinet-office.gov.uk>
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2928 October 24, 2022 08:54 Inactive
@romaricpascal romaricpascal merged commit b793497 into main Oct 24, 2022
@romaricpascal romaricpascal deleted the configuration-changelog-entry branch October 24, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add changelog entry for JavaScript configuration
4 participants