Add warning suppression functionality #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
8830e49
to
614fe69
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
614fe69
to
cb2004a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
cb2004a
to
6bb713b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
36degrees
reviewed
Oct 11, 2022
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
6bb713b
to
c4f7c96
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
c4f7c96
to
062c4f9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
062c4f9
to
07f1181
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
|
Code-wise this is looking pretty cushy to me, but I'll leave the formal review for the folks who've been looking at it for longer. 😉 |
claireashworth
approved these changes
Oct 13, 2022
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
07f1181
to
c181db4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
These are a setting to record which sass warnings users suppressed and a means to interact with said settings respectively.
Specific changes: - Replace all instances of `@warn` with the `_warning` mixin - Add a section explaining the `_warning` mixin and warning suppression
owenatgov
force-pushed
the
warning-suppression-functionality
branch
from
c181db4
to
26611f5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2911
romaricpascal
approved these changes
Oct 13, 2022
|
With 2 approvals I'm gonna go ahead and merge this. There was a slight change since Claire's approval to the managing change docs but this is intended as internal content and can be changed at any time so I'm not worried about this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2890
This PR does the following:
$govuk-suppressed-warningsmap_warningmixin@warnwith the_warningmixinThe
settings/warningssuite ($govuk-suppressed-warningsand_warning) are intended as a way to allow users to suppress deprecation warnings in instances where they're stuck on specific versions so they have the choice to keep their sass compile log clean. It also will allow us to suppress the compatibility mode deprecation warnings in our local legacy app between now and the release of v5.0.More details are in the commit history.