Deprecate settings associated with compatibility mode #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
NickColley
reviewed
Sep 14, 2022
| /// | ||
| /// @access public | ||
|
|
||
| @mixin govuk-compatibility($product) { |
36degrees
reviewed
Sep 14, 2022
There was a problem hiding this comment.
I've generally not reviewed the content of the deprecation warnings – suggest it'd be a good idea to loop @claireashworth in on them, if you haven't already.
owenatgov
force-pushed
the
deprecate-compatibility-mode-settings
branch
from
8ffb9d0
to
3715abc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
|
I just realised I've changed all the warning text but didn't updated the associated tests 🤦🏻 Will sort out. |
claireashworth
approved these changes
Sep 15, 2022
owenatgov
force-pushed
the
deprecate-compatibility-mode-settings
branch
2 times, most recently
from
796399e
to
3b1e449
Compare
|
Tests fixed, ready for re-review! |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
36degrees
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Technical implementation looks solid – thanks @owenatgov 🆒
I think some of the deprecation notices could be clearer, so I've made a some suggestions. I'd also personally prefer we use the full product name ('GOV.UK Frontend') where possible.
owenatgov
force-pushed
the
deprecate-compatibility-mode-settings
branch
from
3b1e449
to
3d5df6d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
36degrees
approved these changes
Sep 26, 2022
36degrees
reviewed
Sep 26, 2022
To suppress lots of warnings when team members run this code locally due to parts of our own code currently using compatibility mode, we temporarily split `govuk-compatibility` into a public and private mixin. The private mixin is just `_govuk-compaitbility` as is and the public mixin references the private mixin but adds a warning. This is specifically to catch when users are using `govuk-compatibility` in their own code.
owenatgov
force-pushed
the
deprecate-compatibility-mode-settings
branch
from
3d5df6d
to
2ccbba4
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2844
owenatgov
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2787
What/Why
Deprecates the public settings influenced by compatibility mode. This PR specifically targets instances when these settings are being used in user-authored sass outside the bounds of the compatibility mode variables. This scenario is unlikely but means we're covering all bases with our deprecation.
More details can be found in the original issue and descriptions of commits.