Only output space after breadcrumbs class if there's an additional class #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Makes sense to me – thanks @frankieroberto. Would you mind adding this fix to the changelog?
|
@36degrees done. Let me know if you need a rebase and force push, or if you’re happy to squash-merge. |
36degrees
changed the title
36degrees
force-pushed
the
minor-fix-breadcrumbs-classes
branch
from
efef01d to
4434857
Compare
|
Thanks @frankieroberto. This just needs a second review and then we can get this merged for you. |
vanitabarrett
approved these changes
Jan 29, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the breadcrumb component from outputting a space after the html class if there are no custom classes to include. This has no impact on end users, but improves consistency with other components, and makes it easier to port the macros to other languages using the test fixtures.
Before
After